Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose custom widgets for google oauth #149

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

jmorag
Copy link
Contributor

@jmorag jmorag commented Mar 7, 2021

I needed this for google specifically, but I'm happy to apply similar changes to the other providers that don't accept custom widget arguments (basically all the non-gaming ones).

@pbrisbin
Copy link
Member

pbrisbin commented Mar 8, 2021

Nice, thanks!

We do something similar for EveOnline, but it offers a set of alternatives with choice by enum, rather than going completely custom. There may be a broader way to solve configurability and normalize with that.

For now, I suggest we keep adding this piece-meal as needed and maybe come back with an overall solution after a few more have cropped up.

@pbrisbin pbrisbin merged commit c4d6a5d into freckle:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants